Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Eligibility Server from GitHub Container Registry #128

Merged
merged 6 commits into from
Oct 7, 2021

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Oct 5, 2021

closes #127

What this PR does

  • Removes the localhost/server implementation and associated artifacts entirely
  • Removes the localhost/server app from Docker Compose and Dev Container configurations
  • Uses the Docker image from https://github.com/cal-itp/eligibility-server as the server instead
  • This PR is currently set to use the package tagged with main

How to test

  • Run Rebuild and Reopen in Container
  • Open the Django application and go through an eligibility flow
  • Run docker ps -f name=server to find the server port and open http://localhost:59000/healthcheck

@thekaveman thekaveman added this to the October 2021 milestone Oct 6, 2021
@machikoyasuda machikoyasuda force-pushed the refactor/remove-server branch from 6cbc517 to a1a18d2 Compare October 6, 2021 19:58
@machikoyasuda
Copy link
Member Author

⚠️ I updated this PR's commit to use my [email protected] email

@machikoyasuda machikoyasuda force-pushed the refactor/remove-server branch from 6bd037b to a1a18d2 Compare October 6, 2021 20:29
@machikoyasuda machikoyasuda marked this pull request as ready for review October 6, 2021 22:03
@machikoyasuda machikoyasuda force-pushed the refactor/remove-server branch from 2028095 to 617cf8e Compare October 6, 2021 22:09
.devcontainer.json Outdated Show resolved Hide resolved
localhost/docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@machikoyasuda machikoyasuda merged commit 2a802b5 into dev Oct 7, 2021
@machikoyasuda machikoyasuda deleted the refactor/remove-server branch October 7, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the server code and related artifacts
2 participants