Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Unverified" page should use translation fields on EligibilityVerifier #379

Closed
Tracked by #317
angela-tran opened this issue Mar 30, 2022 · 0 comments · Fixed by #385
Closed
Tracked by #317

"Unverified" page should use translation fields on EligibilityVerifier #379

angela-tran opened this issue Mar 30, 2022 · 0 comments · Fixed by #385
Assignees
@thekaveman
Labels
bug Something isn't working i18n Copy: Language files or Django i18n framework
Milestone
Courtesy Cards

Comments

@angela-tran
Copy link
Member

To reproduce

Go through the eligibility verification flow such that you will see the "unverified" page that an ineligible user would see.

Expected result

The page shows with translated content.

Actual result

The page shows with translation strings.

image

Thoughts

I think we forgot to update the unverified function in the eligibility app's views when we did #338.
@angela-tran angela-tran added the bug Something isn't working label Mar 30, 2022
@angela-tran angela-tran added this to the Courtesy Cards milestone Mar 30, 2022
@angela-tran angela-tran moved this to This Sprint in Digital Services Mar 30, 2022
@thekaveman thekaveman mentioned this issue Mar 30, 2022
Closed
19 tasks
@thekaveman thekaveman self-assigned this Mar 31, 2022
@thekaveman thekaveman moved this from This Sprint to In Progress in Digital Services Mar 31, 2022
@thekaveman thekaveman mentioned this issue Mar 31, 2022
Merged
@thekaveman thekaveman moved this from In Progress to PR Open in Digital Services Mar 31, 2022
@thekaveman thekaveman added the i18n Copy: Language files or Django i18n framework label Mar 31, 2022
Repository owner moved this from PR Open to Done in Digital Services Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thekaveman thekaveman

Labels
bug Something isn't working i18n Copy: Language files or Django i18n framework
Projects
Digital Services
Archived in project
Milestone
Courtesy Cards
Development

Successfully merging a pull request may close this issue.

Fix: use verifier's translation strings on eligibility unverified page cal-itp/benefits
2 participants
@thekaveman @angela-tran