Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model refactor: PaymentProcessor #2235

Closed
22 tasks done
Tracked by #1666
thekaveman opened this issue Jul 23, 2024 · 0 comments · Fixed by #2262
Closed
22 tasks done
Tracked by #1666

Model refactor: PaymentProcessor #2235

thekaveman opened this issue Jul 23, 2024 · 0 comments · Fixed by #2262
Assignees
Labels
back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, etc.

Comments

@thekaveman
Copy link
Member

thekaveman commented Jul 23, 2024

Acceptance criteria

  • Model renamed to TransitProcessor
  • TransitAgency.payment_processor field renamed to TransitAgency.transit_processor
  • All variable instances renamed to transit_processor
  • All comments updated to remove mention of "payment"
  • client_id moved to TransitAgency.transit_processor_client_id
  • client_secret_name moved to TransitAgency.transit_processor_client_secret_name
  • audience moved to TransitAgency.transit_processor_audience
  • Each field in the model definition has a description
  • Existing Django config data is migrated
  • Docs are updated

Impact on the code

Impact on existing data

  • Standard migrations for model/field renames should maintain existing data
  • Data migration needed to move field data from old PaymentProcessor fields to new TransitAgency fields

Impact on analytics

Impact on Admin permissions

@thekaveman thekaveman added chore Chores and tasks for code cleanup, dev experience, etc. back-end Django views, sessions, middleware, models, migrations etc. labels Jul 23, 2024
@thekaveman thekaveman added this to the Admin tool: agency users milestone Jul 23, 2024
@thekaveman thekaveman moved this from Todo to Stretch in Digital Services Jul 23, 2024
@thekaveman thekaveman changed the title PaymentProcessor model refactors Model refactor: PaymentProcessor Jul 23, 2024
@thekaveman thekaveman self-assigned this Jul 31, 2024
@thekaveman thekaveman moved this from Stretch to In progress in Digital Services Jul 31, 2024
@thekaveman thekaveman moved this from In progress to In review in Digital Services Aug 1, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Digital Services Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. chore Chores and tasks for code cleanup, dev experience, etc.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant