Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match DevSecOps naming convention #1077

Closed
1 of 4 tasks
afeld opened this issue Oct 24, 2022 · 2 comments
Closed
1 of 4 tasks

Match DevSecOps naming convention #1077

afeld opened this issue Oct 24, 2022 · 2 comments
Labels
infrastructure Terraform, Azure, etc.

Comments

@afeld
Copy link
Contributor

afeld commented Oct 24, 2022

The DevSecOps/OET team has naming conventions for their Azure resources, so to be good tenants, we should abide by them. Some notes about them.

Acceptance Criteria

  • All resources match the DevSecOps naming convention

Tasks

  • Get written rules from DevSecOps
  • Update existing resources
  • Add / link to documentation

Additional context

@thekaveman
Copy link
Member

@angela-tran I think we've done this, correct?

@angela-tran
Copy link
Member

angela-tran commented Apr 26, 2023

@thekaveman Yeah, I think #1074 accomplished this.

I do see a comment that implies this ticket here also covers standardizing further / removing inconsistencies within CDT's naming (especially for resources we don't have permission to modify) which might be why it's still open, but that seems like scope creep to me. We at least have those inconsistencies codified in Terraform, so I think until they pose a problem, we can leave them be.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Digital Services Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Terraform, Azure, etc.
Projects
Archived in project
Development

No branches or pull requests

3 participants