From cc9d710094feb3f50d47bea8b1aa29b7121abea6 Mon Sep 17 00:00:00 2001
From: Aidan Feldman <aidan@compiler.la>
Date: Thu, 27 Oct 2022 14:38:37 -0400
Subject: [PATCH] chore(docs): add missing step around Slack notification setup

---
 docs/deployment/infrastructure.md | 5 +++++
 terraform/monitor.tf              | 2 --
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/docs/deployment/infrastructure.md b/docs/deployment/infrastructure.md
index a65f2a0cb4..ae7926e2c0 100644
--- a/docs/deployment/infrastructure.md
+++ b/docs/deployment/infrastructure.md
@@ -83,6 +83,8 @@ All resources in these Resource Groups should be reflected in Terraform in this
 - Secrets, such as values under [Key Vault](https://azure.microsoft.com/en-us/services/key-vault/) and [App Service application settings](https://docs.microsoft.com/en-us/azure/app-service/configure-common#configure-app-settings). [`prevent_destroy`](https://developer.hashicorp.com/terraform/tutorials/state/resource-lifecycle#prevent-resource-deletion) is used on these Resources.
 - [Things managed by DevSecOps](#ownership)
 
+You'll see these represented in Terraform as [data sources](https://developer.hashicorp.com/terraform/language/data-sources).
+
 For browsing the [Azure portal](https://portal.azure.com), you can [switch your `Default subscription filter`](https://docs.microsoft.com/en-us/azure/azure-portal/set-preferences).
 
 ## Monitoring
@@ -180,6 +182,9 @@ lifecycle {
 The following steps are required to set up the environment, with linked issues to automate them:
 
 - `terraform apply`
+- Set up Slack notifications
+  1. [Create a Slack email](https://slack.com/help/articles/206819278-Send-emails-to-Slack) for the [#benefits-notify](https://cal-itp.slack.com/archives/C022HHSEE3F) channel
+  1. [Set it as a Secret in the Key Vault](https://learn.microsoft.com/en-us/azure/key-vault/secrets/quick-create-portal#add-a-secret-to-key-vault) named `slack-benefits-notify-email`
 - Set required [App Service configuration](../configuration/environment-variables.md)
 - Bind the certificate - [#704](https://github.com/cal-itp/benefits/issues/704)
 
diff --git a/terraform/monitor.tf b/terraform/monitor.tf
index 830e774cb1..340bedd6ec 100644
--- a/terraform/monitor.tf
+++ b/terraform/monitor.tf
@@ -22,8 +22,6 @@ resource "azurerm_application_insights" "main" {
   }
 }
 
-# created manually
-# https://slack.com/help/articles/206819278-Send-emails-to-Slack
 data "azurerm_key_vault_secret" "slack_benefits_notify_email" {
   name         = "slack-benefits-notify-email"
   key_vault_id = azurerm_key_vault.main.id