diff --git a/.all-contributorsrc b/.all-contributorsrc index e13736df..7923a813 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -23,6 +23,16 @@ "contributions": [ "code" ] + }, + { + "login": "pascalberger", + "name": "Pascal Berger", + "avatar_url": "https://avatars.githubusercontent.com/u/2190718?v=4", + "profile": "https://github.com/pascalberger", + "contributions": [ + "code", + "doc" + ] } ], "contributorsPerLine": 7, @@ -30,5 +40,6 @@ "projectOwner": "cake-contrib", "repoType": "github", "repoHost": "https://github.com", - "skipCi": true + "skipCi": true, + "commitConvention": "angular" } diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 35cf7eda..f62c85e0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -44,7 +44,7 @@ jobs: steps: - name: Checkout the repository - uses: actions/checkout@v3.1.0 + uses: actions/checkout@v3.3.0 - name: Fetch all tags and branches run: git fetch --prune --unshallow - uses: actions/setup-dotnet@v3.0.3 @@ -57,7 +57,7 @@ jobs: 6.0.x 7.0.x - name: Cache Tools - uses: actions/cache@v3.0.11 + uses: actions/cache@v3.2.4 with: path: tools key: ${{ runner.os }}-tools-${{ hashFiles('recipe.cake') }} @@ -69,7 +69,7 @@ jobs: verbosity: Diagnostic cake-version: 1.3.0 - name: Upload Issues - uses: actions/upload-artifact@v3.1.1 + uses: actions/upload-artifact@v3.1.2 with: if-no-files-found: warn name: ${{ matrix.os }} Issues @@ -77,7 +77,7 @@ jobs: BuildArtifacts/report.html BuildArtifacts/**/coverlet/*.xml - name: Upload Packages - uses: actions/upload-artifact@v3.1.1 + uses: actions/upload-artifact@v3.1.2 if: runner.os == 'Windows' with: if-no-files-found: warn diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 070972d5..ab927127 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -30,7 +30,7 @@ jobs: steps: - name: Checkout the repository - uses: actions/checkout@v3.1.0 + uses: actions/checkout@v3.3.0 - name: Fetch all tags and branches run: git fetch --prune --unshallow - uses: actions/setup-dotnet@v3.0.3 @@ -43,7 +43,7 @@ jobs: 6.0.x 7.0.x - name: Cache Tools - uses: actions/cache@v3.0.11 + uses: actions/cache@v3.2.4 with: path: tools key: ${{ runner.os }}-tools-${{ hashFiles('recipe.cake') }} diff --git a/.github/workflows/publishDocs.yml b/.github/workflows/publishDocs.yml index a218a341..8cb771cb 100644 --- a/.github/workflows/publishDocs.yml +++ b/.github/workflows/publishDocs.yml @@ -15,11 +15,11 @@ jobs: steps: - name: Checkout the repository - uses: actions/checkout@v3.1.0 + uses: actions/checkout@v3.3.0 - name: Fetch all tags and branches run: git fetch --prune --unshallow - name: Cache Tools - uses: actions/cache@v3.0.11 + uses: actions/cache@v3.2.4 with: path: tools key: ${{ runner.os }}-tools-${{ hashFiles('recipe.cake') }} diff --git a/README.md b/README.md index 37f1917a..e00eef4c 100644 --- a/README.md +++ b/README.md @@ -65,10 +65,13 @@ Thanks goes to these wonderful people ([emoji key][emoji-key]): - - - - + + + + + + +

Nils Andresen

💻 🚧

Simon Cropp

💻
Nils Andresen
Nils Andresen

💻 🚧
Simon Cropp
Simon Cropp

💻
Pascal Berger
Pascal Berger

💻 📖
diff --git a/demo/frosting/src2/package.json b/demo/frosting/src2/package.json index 9ae1bd29..7b89884c 100644 --- a/demo/frosting/src2/package.json +++ b/demo/frosting/src2/package.json @@ -9,6 +9,6 @@ "author": "", "license": "ISC", "devDependencies": { - "eslint": "8.27.0" + "eslint": "8.33.0" } } diff --git a/demo/script/src2/package.json b/demo/script/src2/package.json index 9ae1bd29..7b89884c 100644 --- a/demo/script/src2/package.json +++ b/demo/script/src2/package.json @@ -9,6 +9,6 @@ "author": "", "license": "ISC", "devDependencies": { - "eslint": "8.27.0" + "eslint": "8.33.0" } } diff --git a/global.json b/global.json index 7ed6e578..d6201a6e 100644 --- a/global.json +++ b/global.json @@ -1,7 +1,7 @@ { "sdk": { "allowPrerelease": true, - "version": "7.0.100", + "version": "7.0.102", "rollForward": "latestFeature" } } diff --git a/src/Cake.ESLint.Tests/Cake.ESLint.Tests.csproj b/src/Cake.ESLint.Tests/Cake.ESLint.Tests.csproj index e74ac7c0..bcbbdf52 100644 --- a/src/Cake.ESLint.Tests/Cake.ESLint.Tests.csproj +++ b/src/Cake.ESLint.Tests/Cake.ESLint.Tests.csproj @@ -20,10 +20,10 @@ runtime; build; native; contentfiles; analyzers; buildtransitive all - - + + - + all diff --git a/src/Cake.ESLint/ESLintCacheStrategy.cs b/src/Cake.ESLint/ESLintCacheStrategy.cs index 90c151e5..464e73d1 100644 --- a/src/Cake.ESLint/ESLintCacheStrategy.cs +++ b/src/Cake.ESLint/ESLintCacheStrategy.cs @@ -35,17 +35,17 @@ private ESLintCacheStrategy(string name) } /// - /// Gets the fix-type: Problem. + /// Gets the cache strategy "metadata". /// public static ESLintCacheStrategy Metadata { get; } = new ESLintCacheStrategy("metadata"); /// - /// Gets the fix-type: Suggestion. + /// Gets the cache strategy "content". /// public static ESLintCacheStrategy Content { get; } = new ESLintCacheStrategy("content"); /// - /// Gets the name of the problem. + /// Gets the name of the cache strategy. /// public string Name { get; } } diff --git a/src/Cake.ESLint/ESLintRunner.cs b/src/Cake.ESLint/ESLintRunner.cs index 938ad75b..dd2e2d17 100644 --- a/src/Cake.ESLint/ESLintRunner.cs +++ b/src/Cake.ESLint/ESLintRunner.cs @@ -279,6 +279,7 @@ private void RegisterLocalLintTool(ToolSettings settings) // instead of any other version. if (settings.NoWorkingDirectory || settings.WorkingDirectory == null) { + log.Verbose($"No working directory set."); return; } @@ -286,6 +287,7 @@ private void RegisterLocalLintTool(ToolSettings settings) fileSystem.GetDirectory(settings.WorkingDirectory.Combine("node_modules/.bin")); if (!nodeBin.Exists) { + log.Warning($"node_modules/.bin does not exist in {settings.WorkingDirectory.FullPath}."); return; }