Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Url argument to be System.Uri #67

Closed
AdmiringWorm opened this issue Jan 7, 2020 · 0 comments
Closed

Change Url argument to be System.Uri #67

AdmiringWorm opened this issue Jan 7, 2020 · 0 comments
Assignees
@AdmiringWorm
Labels
Breaking change
Milestone
0.8.0

Comments

@AdmiringWorm
Copy link
Member

To follow best pratices, we should change the Url property from a string to System.Uri.

This will be considered a breaking change.

Ref: https://sonarcloud.io/project/issues?id=cake-contrib_Cake.Codecov&issues=AW-ActKRpjn0nASQ9z9C&open=AW-ActKRpjn0nASQ9z9C
@AdmiringWorm AdmiringWorm added this to the 0.8.0 milestone Jan 7, 2020
@AdmiringWorm AdmiringWorm self-assigned this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
Breaking change
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@AdmiringWorm