Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InspectCode: Add support for /verbosity and /severity arguments #2683

Merged
merged 2 commits into from
Dec 19, 2019
Merged

InspectCode: Add support for /verbosity and /severity arguments #2683

merged 2 commits into from
Dec 19, 2019

Conversation

fafanoulele
Copy link

💡 It fixes the issue #2328.

This PR adds the support of the arguments /verbosity and /severity for the tool InspectCode.

@fafanoulele fafanoulele force-pushed the 2328-inspectcode-verbosity-severity branch from b9a01db to b48b618 Compare December 6, 2019 16:52
@fafanoulele
Copy link
Author

It looks like that the build fails because of the name of the Git branch I've used.
Error:

Chocolatey v0.10.15
'0.36.0-2328-inspectcode0001' is not a valid version string.
Parameter name: version
An error occurred when executing task 'Create-Chocolatey-Packages'.

Please let me know if you want me to do something about that (e.g. use another branch name).

@devlead devlead force-pushed the 2328-inspectcode-verbosity-severity branch from b48b618 to a3c7aeb Compare December 9, 2019 12:13
@devlead devlead force-pushed the 2328-inspectcode-verbosity-severity branch from a3c7aeb to a5f9a2e Compare December 19, 2019 10:13
devlead
devlead approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit a5f9a2e into cake-build:develop Dec 19, 2019
@devlead
Copy link
Member

devlead commented Dec 19, 2019

@fafanoulele your changes have been merged, thanks for your contribution 👍

Sorry for the delay in feedback, we used your PR to find a workaround for the GitVersion issue.

@devlead devlead mentioned this pull request Dec 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fafanoulele @devlead