-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GitHub Action workflow commands #2863
Comments
Is this related to #2609? |
Yes. The question is what the scope of #2609 is? Part is already done in IGitHubActionsProvider (access to environment variables), another with the Cake Action, support of workflow commands is another part where this issues overlaps with #2609, and having additional helpers for stuff like uploading artifacts, which is not supported by workflow commands is the third part. Wouldn't it be better to close #2609 and create individual issues for the remaining issues instead? |
I started working on #2609 already and I was actually thinking about implementing this, as well. Adding support for interacting with GitHub Actions could still be tracked in #2609, but I'll create separate PRs for each area (environment, commands etc). Would that be fine or would you rather track them as individual issues? |
As we use issues for or release notes, if it's separate features enough to warrant multiple PRs, then I think we should split into multiple issues. |
The way I see it, adding complete support for interacting with GitHub Actions is one feature. But I'm fine with splitting it up, if you prefer. |
The confusing thing is, that part of it already has shipped with current version of Cake and remaining parts probably might ship in different versions. Therefore I'm with @devlead on this, that separate issues make sense in this case, since we're using them for release notes. |
Since I'm already working on #2609, I'll take on this one, as well. |
🎉 This issue has been resolved in version v3.0.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
What You Are Seeing?
The IGitHubActionsProvider currently gives access to some environment values.
What is Expected?
It should also provide Workflow commands
What version of Cake are you using?
0.38.5
Are you running on a 32 or 64 bit system?
64 bit
What environment are you running on? Windows? Linux? Mac?
N/A
Are you running on a CI Server? If so, which one?
GitHub Actions
How Did You Get This To Happen? (Steps to Reproduce)
N/A
Output Log
N/A
The text was updated successfully, but these errors were encountered: