Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XmlPoke always writes the xmldeclaration even if the original file didn't have one #1759

Closed
Roemer opened this issue Aug 19, 2017 · 2 comments
Labels
Milestone

Comments

@Roemer
Copy link
Contributor

Roemer commented Aug 19, 2017

As the title says, when using XmlPoke, it always writes the declaration.

There are two possibilities:

  1. Add an OmitXmlDeclaration flag to XmlPokeSettings to define if the declaration should be written or not.
  2. Check in XmlPoke if the original one has a declaration and either write it or not.

Which one should we prefer?

@gep13
Copy link
Member

gep13 commented Aug 19, 2017

@Roemer of the two options, I think I prefer the second one.

@cake-build/cake-team ?

@Roemer
Copy link
Contributor Author

Roemer commented Aug 19, 2017

I crated a PR with solution 2.

@devlead devlead added the Bug label Aug 29, 2017
@devlead devlead added this to the v0.22.0 milestone Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants