HandleRpcError: Add RpcError handling in tgis_utils #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-l-hart
requested review from
alex-jw-brooks,
gkumbhat,
evaline-ju,
tharapalanivel and
Ssukriti
as code owners
gkumbhat
reviewed
May 13, 2024
| grpc.StatusCode.RESOURCE_EXHAUSTED: CaikitCoreStatusCode.UNKNOWN, | ||
| grpc.StatusCode.FAILED_PRECONDITION: CaikitCoreStatusCode.UNKNOWN, | ||
| grpc.StatusCode.ABORTED: CaikitCoreStatusCode.CONNECTION_ERROR, | ||
| grpc.StatusCode.OUT_OF_RANGE: CaikitCoreStatusCode.UNKNOWN, |
There was a problem hiding this comment.
Conversions are lossy, but kind of make sense from changing the view of runtime to library.... For some of these, like the OUT_OF_RANGE, might make sense to expose at library level as well ? Or may be we can map it to FAILED_PRE_CONDITION since there is a overlap as per doc here
Also the FAILED_PRECONDITION might come in handy, which is getting mapped to UNKNOWN above 🤔
There was a problem hiding this comment.
Yeah, I was trying to make this work without changing caikit itself. I think there is almost certainly an important API-breaking change conversation to be had about how the internal error codes map to well-known error code enums (grpc/http) and how to avoid information loss.
gkumbhat
reviewed
May 13, 2024
gkumbhat
approved these changes
May 14, 2024
caikit#354 Signed-off-by: Gabe Goodhart <[email protected]>
gabe-l-hart
force-pushed
the
HandleRpcError-354
branch
from
129acb8 to
b01c0e4
Compare
caikit#354 Signed-off-by: Gabe Goodhart <[email protected]>
gkumbhat
approved these changes
May 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds error handling for
grpc.RpcErrors raised during calls to TGIS intgis_utils.Closes: #354