Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with core effect (dnd5e system) #54

Open
CaosFR opened this issue Sep 7, 2024 · 6 comments
Open

Bug with core effect (dnd5e system) #54

CaosFR opened this issue Sep 7, 2024 · 6 comments

Comments

@CaosFR
Copy link

CaosFR commented Sep 7, 2024

Hi ,

Thanks for your great module. If I use the variant encombered of dnd5e system I have a bug with your module :

Foundry v12
Dnd 3.31
Terrain mapper 0.4.5
No other module enable

image

@CaosFR CaosFR changed the title Bug with variant encombered Bug with variant encombered (dnd5e system) Sep 7, 2024
@CaosFR
Copy link
Author

CaosFR commented Sep 7, 2024

Update, it's the same for all core effect. Exemple with poisoned

game:1 Uncaught (in promise) Error: undefined. The _id [dnd5epoisoned000] already exists within the parent collection: Actor [OJUmW18chuMQBzml] effects
[No packages detected]
    at /home/foundry/resources/app/dist/database/backend/server-backend.mjs:1:3158
    at Array.map (<anonymous>)
    at ServerDatabaseBackend._createDocuments (/home/foundry/resources/app/dist/database/backend/server-backend.mjs:1:3073)
    at ServerDatabaseBackend.create (/home/foundry/resources/app/common/abstract/backend.mjs:77:17)
    at async Semaphore._try (/home/foundry/resources/app/common/utils/semaphore.mjs:101:17)

@CaosFR CaosFR changed the title Bug with variant encombered (dnd5e system) Bug with all core effect (dnd5e system) Sep 7, 2024
@caewok
Copy link
Owner

caewok commented Sep 12, 2024

What are you doing to get the error to show up? Can you walk me through the steps?

@CaosFR
Copy link
Author

CaosFR commented Sep 17, 2024

Thanks for your reply. I have made some tests.

It's very strange, The problem stems from an incompatibility between midi-qol (https://github.com/thatlonelybugbear/automated-conditions-5e) and your work. I hadn't checked because I was think your modules complementary (my fault).

If I disable your module or midi-qol it's ok (no error). I have try with differents configurations of midi (full automate, no automate), the problem persist.

The problem arises when you call up an effect that calls up the incapacitated effect (such as paralyzed, stunned, etc.).

Step to reproduce :

  • Active Midi-Qol and your module (other modules are disables)
  • Add a effect to a token which calls for incapacitated (like stunned)
  • See error

Other bug, If I open terrain book (with dfreds-convenient-effects active to). I dont think is linked, do you want a other issue ?

image

@CaosFR CaosFR changed the title Bug with all core effect (dnd5e system) Bug with core effect (dnd5e system) Sep 17, 2024
@tweener67
Copy link

I have also seen a similar result which occurs anytime I use an active effect to add a condition it throws "The _id [dnd5ecursed00000] already exists within the parent collection". When the effect is later removed it throws "ActiveEffect "dnd5ecursed00000" does not exist!". I've tried adding a different condition and it throws dnd5e[condition] for each one.

In my case I have a spell which under effects applies a temporary condition. I have tried different conditions and it seems to work for all of them. Turning off Terrain-Mapper makes the error go away. I have not tried turning off MIDIQOL.

From the console window I get the following:

The _id [dnd5ecursed00000] already exists within the parent collection: Actor [RMuYEyBfrt6DrMy9] effects

Uncaught (in promise) Error: The _id [dnd5ecursed00000] already exists within the parent collection: Actor [RMuYEyBfrt6DrMy9] effects
[No packages detected]
at /opt/foundryvtt/dist/database/backend/server-backend.mjs:1:3158
at Array.map ()
at ServerDatabaseBackend._createDocuments (/opt/foundryvtt/dist/database/backend/server-backend.mjs:1:3073)
at ServerDatabaseBackend.create (/opt/foundryvtt/common/abstract/backend.mjs:77:17)
at async Semaphore._try (/opt/foundryvtt/common/utils/semaphore.mjs:101:17)

When removing the effect:

ActiveEffect "dnd5ecursed00000" does not exist!

foundry.js:3477 Uncaught (in promise) Error: ActiveEffect "dnd5ecursed00000" does not exist!
[No packages detected]
at file:///opt/foundryvtt/dist/database/backend/server-backend.mjs:1:6671
at Array.map ()
at ServerDatabaseBackend._deleteDocuments (file:///opt/foundryvtt/dist/database/backend/server-backend.mjs:1:6641)
at ServerDatabaseBackend.delete (file:///opt/foundryvtt/common/abstract/backend.mjs:174:17)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Semaphore._try (file:///opt/foundryvtt/common/utils/semaphore.mjs:101:17)

@CaosFR
Copy link
Author

CaosFR commented Nov 19, 2024

Hi, any news ?

@TimorSol
Copy link

TimorSol commented Dec 8, 2024

I bumped into an similar issue in the A5e system. The same thing happens when I try to remove an effect as described in the post from @tweener67.
When any token "falls" to 0 HP, the effects they get applied automatically (dead, defeated or unconscious or prone) are doubled or sometimes trippled. I have narrowed down the issue to strictly terrain mapper, no other modules are on.

Replicate: take a token and make it take damage that takes it below 0HP. Example below, a double incapacitated character.

obraz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants