-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove OCSP warnings #327
Comments
Well, there are already public certs that don't support OCSP. That is the point of the warning: we can't automatically replace a certificate that has been revoked if it doesn't have OCSP. So it is beneficial to warn the user when that is the case. |
CRL URLs? Maybe only warn if there is neither a OCSP URL nor a CRL URL? |
Caddy doesn't use CRLs though. (It's infeasible AFAIK.) So there's no benefit to warning, since it's not an expected feature or function of Caddy. |
Ok. But then in 3 months, there will be warnings when using Let's Encrypt all over since OCSP is no longer supported. That's why I think it would be a good idea to allow to disable the unavoidable warnings. |
I'll give this some thought. I don't want to induce "warning fatigue", but I also want users to know when they use a CA that does not support a critical privacy feature. |
But certmagic is not limited to Caddy. Unless it is developed primarily for use with Caddy? |
That's true. Sometimes I lose track of which repo I'm in. The point remains though: CertMagic is the library that is managing renewals and checking revocation. |
Maybe I am missing the point here or don't completely understand the topic: The thing about OCSP stapling is that it caches the validity from CA and sends it to the clients so that they don't have the ask the CA itself and leak information. So OCSP without stapling should give a warning, but no OCSP at all, but CRL support, should be sufficient. |
Well, to clarify, CertMagic uses revocation status as a clue to renew early. So, yes, OCSP and CRLs are normally concerns of the clients, but in TLS automation, they are of interest by the servers too. (Well, the good ones. 😇) The problem is that there's not really a feasible way to implement revocation checking via CRLs, so that is probably of concern to the user: if their certificate is added to a CRL, CertMagic won't know it and replace the revoked certificate. Hence, the warning that that kind of protection will be missing. |
That's fair. Why is it not feasible? CRL size being burdensome to download and search through periodically? |
Ah, found it -- there was a big discussion over the course of several years in this issue: caddyserver/caddy#2341 So, yes, that's basically right.
Implementation is just very tricky and there's lots of technical details to figure out. |
That's really unfortunate, and I can't think of a good solution other than what would basically being re-inventing OCSP. But thank you for answering! |
Actually the code is used at least in production in our company (deployed at arround 10 installations) and also part of our ci/cd chain. But i doubt that our usage covers all possible use cases of CRL. For example delta lists and ldap are not supported by my implementation. And there are so many "switches" in the crl extensions... As @mholt suspected, the problem is that I don't have enough time to fully support this project with the attention it needs. |
What would you like to have changed?
Let's Encrypt will stop supporting OCSP ( https://letsencrypt.org/2024/12/05/ending-ocsp/ ), so there should be an option to disable the warnings or the warnings should be completely removed or downgraded to debug.
The text was updated successfully, but these errors were encountered: