Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptableThrowawayItems is being moved into players hotbar, when baritone is inactive #3409

Open
Rumrobot opened this issue Apr 21, 2022 · 4 comments · May be fixed by #4037
Open

acceptableThrowawayItems is being moved into players hotbar, when baritone is inactive #3409

Rumrobot opened this issue Apr 21, 2022 · 4 comments · May be fixed by #4037
Labels
enhancement New feature or request

Comments

@Rumrobot
Copy link

Rumrobot commented Apr 21, 2022

Describe your suggestion

Add a setting, or remove the thing where baritone constantly moves acceptableThrowawayItems into the player's hotbar. Or at least make it so it doesn't do it while baritone is inactive. Then there is no need for it.

Settings

There could be a setting for it, but it isn't necessary. Something like acceptableThrowawayItemsPriority = true/false could maybe work.

Context

It's annoying when playing Minecraft, and the acceptableThrowawayItems is being moved into the player's hotbar. It's interrupting a lot when playing.

@Rumrobot Rumrobot added the bug Something isn't working label Apr 21, 2022
@ZacSharp
Copy link
Collaborator

This is a feature you explicitly enabled by setting allowInventory to true, why are you reporting it as a bug?
If you think the intended behaviour should be changed you should open a "suggestion issue instead of reporting the current behaviour as a bug.

I'll just change the label and it would be nice if you could edit your issue to contain a little more information (look at the suggestion template for what to put in it).

@ZacSharp ZacSharp added enhancement New feature or request and removed bug Something isn't working labels Apr 21, 2022
@Rumrobot
Copy link
Author

Thx i will do that, but i would call it a bug since baritone is inactive. Is it made to specifically do it like that? And then what would the point be to have it do it, while it has nothing to do?

@ZacSharp
Copy link
Collaborator

I think that's intended. It's doing it here

swapWithHotBar(firstValidThrowaway(), 8);
since the inventory handling was added 3 years ago and I never saw a sign of someone considering it wrong behavior. There is checks to disable it in containers or while not ingame (and of course when allowInventory is disabled) but nothing to check whether we actually need the items.

@liangforstudy
Copy link

liangforstudy commented Apr 27, 2022

Oh yeah, I find this annoying as well. Sometimes there's a cobblestone/dirt block on my 9th slot on my hotbar. And when I tried to keep that in my inventory, Baritone keep placing it back into my 9th slot on my hotbar until I turn @ allowinventory off.
But I also needed baritone to access my inventory for convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants