Improve Oncoprint Add-track UI #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aditygrg2 thanks for this one. One small thing, the Add Track button stretches verically as the list of items grows. Seems like a small tweak will fix this nicely: |
|
Nice suggestion @alisman Updated the PR, now the button is aligned at the center. I thought to take the button down (as the third row) but then the button was not visible when the second select field is elapsed, so this design looks good. |
alisman
force-pushed
the
tweak-onco
branch
3 times, most recently
from
daa52bc to
aa28319
Compare
|
@aditygrg2 thanks for this one. i'm trying to fix some end to end tests related to this change and did a couple force pushes to this branch FYI |
alisman
force-pushed
the
tweak-onco
branch
6 times, most recently
from
70f98c3 to
04534df
Compare
alisman
force-pushed
the
tweak-onco
branch
4 times, most recently
from
0e868c8 to
a624fdc
Compare
|
@aditygrg2 thank you for this PR. Apologies it took so long to merge. There was an issue with our end-to-end tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#10057
Describe changes proposed in this pull request:
Swapped the select fields on Oncoprint study view -> Add Track filters, which improves user experience for avoiding careful click after selecting and click "Add Track" button.
Before:
After:
