Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

Transport disconnect does not have reason for a stream connection. #19

Open
LiamKarlMitchell opened this issue Jun 25, 2015 · 0 comments

Comments

@LiamKarlMitchell
Copy link

in smith.js Transport onDisconnect

self.emit("disconnect")
is not going to pass any sort of reason.

Maybe the function needs to have err as its first parameter and then self.emit("disconnect", err)

The problem is happening on a friends computer so I can't debug to prove it just yet but will try to get a working example later.

Thought I should raise issue just in case it is something that was neglected.
The documentation seems to say onDisconnect event would have a reason. But it is not always the case?.

See these lines.
https://github.com/c9/smith/blob/master/smith.js#L113-127

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant