Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paragliding waypoints #817

Open
cbeauchesne opened this issue May 8, 2020 · 1 comment
Open

Paragliding waypoints #817

cbeauchesne opened this issue May 8, 2020 · 1 comment
Labels
Good first issue

Comments

@cbeauchesne
Copy link
Member

  • remove exposition_rating
  • change DB values paragliding_rating from 5 to 4
  • change the scale of paragliding_rating from [1-5] to [1-4]
@jbelis
Copy link

jbelis commented Feb 8, 2024 •
edited
Loading

This was created a long time ago. Is it still entirely relevant?

  • I see that waypoynt.exposition_rating is still in the data model. It is defined in search mappings ('pglexp' attribute). But it does not seem to be used by the UI. 'pgrat' seems to be used.
  • it seems that the range of waypoint.paragliding_rating has already been set to 1-4 (see https://github.com/c2corg/v6_api/blob/master/c2corg_api/models/common/attributes.py line 118)
  • no SQL migration seems to impact "paragliding_rating" so there are possibly waypoints with an out of range value. But if so i am wondering why the data layer would not complain when accessing illegal enum values

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbelis @cbeauchesne