Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all examples to work in 1.3.0 #3

Closed
diarmidmackenzie opened this issue Oct 1, 2022 · 3 comments
Closed

Update all examples to work in 1.3.0 #3

diarmidmackenzie opened this issue Oct 1, 2022 · 3 comments

Comments

@diarmidmackenzie
Copy link
Member

diarmidmackenzie commented Oct 1, 2022

Goal: all existing examples working in 1.3.0.

Progress so far on branch "examples-to-1.3"

  • Updated examples to use A-Frame 1.3.0
  • Updated to use three-to-cannon v4
  • Updated examples to use latest environment component & sphere colliders
  • Updated CANNON-shape2mesh to use BufferGeometry rather than Geometry. This affects all of: convex polyhedron, trimesh & heightfield. These all need testing, but existing examples don't cover all of these.
  • Updated invert -> inverse for Quaternions (reflecting THREE.js interface change)

Examples all now seem to run cleanly with no errors, but some behaviour issues remain...

Current status:

  • ammo - OK
  • cannon - Turning "debug" on reveals that cylinder and cone physics geometries are out by 90 degrees.
  • compound - Need to test interactions in VR (can't test on desktop)
  • constraints-ammo - OK
  • constraints - Need to test interactions in VR (can't test on desktop)
  • materials - Interactions (force-pushable) don't seem to work (though this works in other examples)
  • spring - OK
  • stress- Mostly OK. Interactions (force-pushable) seem only about 90% reliable?
  • sweeper - Sweeper bar does not sweep the objects away
  • ttl - Cylinder physics geometry is rotated 90 degrees vs visible geometry.

Also, some examples use teleport controls, which generates a warning, but there doesn't seem to be a fix available yet.

@diarmidmackenzie
Copy link
Member Author

diarmidmackenzie commented Oct 1, 2022

Geometries out by 90 degrees was an issue with my three-to-cannon v4 updates. Now fixed.

Remaining issues:

  • compound - Need to test interactions in VR (can't test on desktop)
  • constraints - Need to test interactions in VR (can't test on desktop)
  • materials - Interactions (force-pushable) don't seem to work (though this works in other examples)
  • stress- Mostly OK. Interactions (force-pushable) seem only about 90% reliable?
  • sweeper - Sweeper bar does not sweep the objects away
  • ttl - TTL timer happens for box, but not for cylinder or sphere. Unclear whether that is expected...?

My latest efforts are published here

@diarmidmackenzie
Copy link
Member Author

diarmidmackenzie commented Oct 1, 2022

More fixes

  • issues with force-pushable resolved by tightening up raycast targets
  • added interactivity to compound & constraints
  • ttl - Having read code more clearly, I see this is exactly what's supposed to happen - only the box has the relevant mixin to make it disappear.

remaining issues are:

  • materials - Interactions (force-pushable) still don't work (though this works in other examples)
  • sweeper - Sweeper bar does not sweep the objects away

@diarmidmackenzie
Copy link
Member Author

Remaining problems with materials & sweeper are due to these examples using "driver: worker".

Using the non-physics driver, both work fine. I have updated these examples not to use "driver: worker" and will raise a new issue to track getting "driver: worker" fully operational.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant