Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer ownership to c-frame organization #43

Closed
vincentfretin opened this issue Jan 6, 2023 · 2 comments
Closed

Transfer ownership to c-frame organization #43

vincentfretin opened this issue Jan 6, 2023 · 2 comments

Comments

@vincentfretin
Copy link
Member

Hi @mwbeene,
Are your interested in transferring ownership of this repository to the c-frame organization so other maintainers like me can help with the PRs and issues? If you are I'll invite you to the c-frame organization so you can transfer the repository. I'll also need to have the owner permission on npm (username vincentfretin) so I can make new releases.
If you don't want to add new features to the component, I'll respect that. I'll just create a fork in the c-frame organization and release the fork as @c-frame/cursor-teleport, but I wanted to suggest the transfer first before doing so.

Some changes I have in my personal project that could be contributed here:

  • Change the cursor to add a cylinder similar to blink-controls (included in fork https://github.com/kfarr/aframe-cursor-teleport)
  • Animation on the cylinder cursor (included in fork https://github.com/kfarr/aframe-cursor-teleport)
  • Raycast only on click, don't show the cursor on mousemove on desktop (could be an option, to be discussed)
  • If we have a raycaster on scene, ignore all objects of this raycaster (or a variant of it, to be discussed)
  • Disable simple-navmesh-constraint during teleport transition if it's used (we should do the same if you're using movement-controls with constrainToNavMesh:true)
  • Add new API teleportTo(position, quaternion), quaternion optional, with rotation y transition, also fix look-controls pitchObject.rotation.x if needed, to be used via buttons to change camera view

Other changes I was thinking:

  • Update the build dependencies (webpack)
  • Add a color property to change the color of the cursor.
@vincentfretin
Copy link
Member Author

The repo was transferred in the c-frame organization and I have now the right to publish on npm.
Thank you @mwbeene!
I'll create separate issues for the above later.

@vincentfretin
Copy link
Member Author

I updated webpack and released version 1.1.1.
From the suggested enhancements above I created:

I didn't create an issue for:

  • If we have a raycaster on scene, ignore all objects of this raycaster (or a variant of it, to be discussed)

That's too specific to my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant