From a9f26f93e6553fe2118e44758ba42a8472120eec Mon Sep 17 00:00:00 2001 From: Boris Zbarsky Date: Thu, 7 Sep 2023 11:56:22 -0400 Subject: [PATCH] Address review comments. --- scripts/tests/yaml/runner.py | 3 ++- src/app/tests/suites/TestClusterMultiFabric.yaml | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/tests/yaml/runner.py b/scripts/tests/yaml/runner.py index 10187eb46d2c7e..746fc01656f135 100755 --- a/scripts/tests/yaml/runner.py +++ b/scripts/tests/yaml/runner.py @@ -260,10 +260,11 @@ def runner_base(ctx, configuration_directory: str, test_name: str, configuration specifications = SpecDefinitionsFromPaths(specifications_paths.split(','), pseudo_clusters) tests_finder = TestsFinder(configuration_directory, configuration_name) - parser_config = TestParserConfig(pics, specifications, kwargs) test_list = tests_finder.get(test_name) if len(test_list) == 0: raise Exception(f"No tests found for test name '{test_name}'") + + parser_config = TestParserConfig(pics, specifications, kwargs) parser_builder_config = TestParserBuilderConfig(test_list, parser_config, hooks=TestParserLogger()) parser_builder_config.options.stop_on_error = stop_on_error while ctx: diff --git a/src/app/tests/suites/TestClusterMultiFabric.yaml b/src/app/tests/suites/TestClusterMultiFabric.yaml index 7ca177dcbb67aa..8d3febcf410034 100644 --- a/src/app/tests/suites/TestClusterMultiFabric.yaml +++ b/src/app/tests/suites/TestClusterMultiFabric.yaml @@ -330,6 +330,7 @@ tests: # These should actually be missing, not null, but right # now our harness treats those the same, and we have no # way to indicate "missing" in the YAML. + # https://github.com/project-chip/connectedhomeip/issues/29110 fabricSensitiveInt8u: null, optionalFabricSensitiveInt8u: null, nullableFabricSensitiveInt8u: null, @@ -342,6 +343,7 @@ tests: # These should actually be missing, not null, but right # now our harness treats those the same, and we have no # way to indicate "missing" in the YAML. + # https://github.com/project-chip/connectedhomeip/issues/29110 fabricSensitiveInt8u: null, optionalFabricSensitiveInt8u: null, nullableFabricSensitiveInt8u: null, @@ -364,6 +366,7 @@ tests: # These should actually be missing, not null, but right # now our harness treats those the same, and we have no # way to indicate "missing" in the YAML. + # https://github.com/project-chip/connectedhomeip/issues/29110 fabricSensitiveInt8u: null, optionalFabricSensitiveInt8u: null, nullableFabricSensitiveInt8u: null, @@ -376,6 +379,7 @@ tests: # These should actually be missing, not null, but right # now our harness treats those the same, and we have no # way to indicate "missing" in the YAML. + # https://github.com/project-chip/connectedhomeip/issues/29110 fabricSensitiveInt8u: null, optionalFabricSensitiveInt8u: null, nullableFabricSensitiveInt8u: null,