feat(cmd): allow reading input from stdin #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 81.67% 81.71% +0.03%
==========================================
Files 35 35
Lines 2096 2100 +4
==========================================
+ Hits 1712 1716 +4
Misses 258 258
Partials 126 126 |
|
thanks for this PR, @raghur! Would you mind adding a test that reads from |
|
oops, closed by error, sorry about that :/ |
|
There a test for that.. Check the diff. |
golangci
reviewed
Apr 21, 2018
cmd/libasciidoc/root_cmd_test.go
Outdated
| @@ -49,6 +54,36 @@ var _ = Describe("root cmd", func() { | |||
| GinkgoT().Logf("command output: %v", buf.String()) | |||
| require.Error(GinkgoT(), err) | |||
| }) | |||
|
|
|||
|
ah, my bad, I missed it (facepalm) |
|
thanks @raghur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow reading input for stdin -
libasciidoc -s --s, --source string the path to the asciidoc source to process. Use '-' for reading from stdin