bug(renderer): source highlighter should get unadulterated string #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ths fix for this involved some refactoring of the highlighting work to separate out the calloouts (we embed them using reserved Unicode so that we can find them again and replace them inline). Chroma automatically escapes the code for HTML safetly already, so we defer to it's rules, when we use it. We still have to do this ourselves when not using Chroma. Fixes bytesparadise#721
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 84.92% 84.94% +0.02%
==========================================
Files 75 75
Lines 5120 5175 +55
==========================================
+ Hits 4348 4396 +48
- Misses 488 492 +4
- Partials 284 287 +3 |
|
Any feedback on this one? |
I plan to review it later today |
|
thanks @gdamore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths fix for this involved some refactoring of the highlighting work
to separate out the calloouts (we embed them using reserved Unicode so
that we can find them again and replace them inline).
Chroma automatically escapes the code for HTML safetly already, so
we defer to it's rules, when we use it. We still have to do this
ourselves when not using Chroma.
Fixes #721