Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for : (and inline images, icons) in definition list terms #615

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

gdamore
Copy link
Collaborator

@gdamore gdamore commented Jun 16, 2020

This PR is based upon the work for icons (PR #613). Only the last commit here is relevant.

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #615 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files          69       69           
  Lines        4322     4322           
=======================================
  Hits         3751     3751           
  Misses        363      363           
  Partials      208      208           

Copy link
Member

@xcoulon xcoulon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please rebase the PR after #613 was merged and replace the bug(parser) prefix with fix(parser) in the commit msg ;)

@xcoulon xcoulon merged commit b61a886 into bytesparadise:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants