test(parser): verify configuration attributes #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
- Coverage 86.38% 86.23% -0.15%
==========================================
Files 67 67
Lines 4707 4723 +16
==========================================
+ Hits 4066 4073 +7
- Misses 474 480 +6
- Partials 167 170 +3 |
include all document attributes, including overrides in the returned "parsed document" after processing the draft document returned by the parser. Those attributes can then be consumed by the renderer, when applicable, also: refactor predefined attributes (moved to pkg/types) Fixes ∞509 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue509_with_attributes_error
branch
from
f35ca56 to
0336d5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test to verify that custom attributes
passed in the configuration work as expected
Updates #509
Signed-off-by: Xavier Coulon [email protected]