feat(parser/renderer): support element ID prefix #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Feb 24, 2019
pkg/types/element_attributes.go
Outdated
| // AttrSource the "source" attribute for a source block or a source paragraph (this is a placeholder, ie, it does not expect any value for this attribute) | ||
| AttrSource string = "source" | ||
| // attrsource the "source" attribute for a source block or a source paragraph (this is a placeholder, ie, it does not expect any value for this attribute) | ||
| attrsource string = "source" |
There was a problem hiding this comment.
attrsource is unused (from deadcode)
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=========================================
+ Coverage 84.35% 84.45% +0.1%
=========================================
Files 38 39 +1
Lines 3898 3931 +33
=========================================
+ Hits 3288 3320 +32
- Misses 472 473 +1
Partials 138 138 |
Fixes bytesparadise#300 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue300_idprefix
branch
from
cff472f to
d2300d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300