fix(renderer): avoid double encoding of document attributes #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcoulon
force-pushed
the
Issue295_attributes_encoding
branch
from
bf77231 to
7a002c5
Compare
render all elements and apply substitutions, then if applicable (ie, there were some substitutions), then parse the inline elements again and render the elements, but with plain string output for the StringElements to avoid double HTML escaping also: - do not treat `++` as an empty single plus passthrough (but keep `++++++` as an empty triple plus passthrough for now) - render `++` as `&bytesparadise#43;&bytesparadise#43;` - accept that `InlineElementsWithoutSubtitution` can be empty (which happens if the only content was `{blank}` which is trimmed after rendering) fixes bytesparadise#295 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue295_attributes_encoding
branch
from
7a002c5 to
e63f9ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
- Coverage 85.17% 84.25% -0.92%
==========================================
Files 38 38
Lines 3851 3887 +36
==========================================
- Hits 3280 3275 -5
- Misses 432 474 +42
+ Partials 139 138 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unescape the document attributes substitution before it
is escaped again
fixes #295
Signed-off-by: Xavier Coulon [email protected]