Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escaped string in GetOnDemand #77

Merged
merged 7 commits into from
Jun 30, 2023
Merged

fix: escaped string in GetOnDemand #77

merged 7 commits into from
Jun 30, 2023

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Jun 28, 2023

Main Changes:

  1. fix the bugs when string has esacped chars in GetOnDemand
  2. export the GetOnDemand API
  3. reduce the repeated codes In different archs

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #77 (5ee1acf) into master (4825b5e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   95.78%   95.77%   -0.02%     
==========================================
  Files          21       21              
  Lines        2445     2435      -10     
==========================================
- Hits         2342     2332      -10     
  Misses        103      103              
Impacted Files Coverage Δ
include/sonic/error.h 100.00% <ø> (ø)
include/sonic/internal/arch/avx2/base.h 100.00% <ø> (ø)
include/sonic/internal/arch/avx2/unicode.h 100.00% <ø> (ø)
include/sonic/internal/arch/simd_skip.h 88.33% <ø> (-0.90%) ⬇️
include/sonic/dom/generic_document.h 95.60% <100.00%> (ø)
include/sonic/dom/parser.h 94.36% <100.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liuq19
Copy link
Collaborator Author

liuq19 commented Jun 29, 2023

Performace compare in x86:

Benchmark                                            Time             CPU      Time Old      Time New       CPU Old       CPU New
---------------------------------------------------------------------------------------------------------------------------------
twitter/SonicOnDemand_Normal                      -0.0024         -0.0044         25968         25906         25949         25834
citm_catalog/SonicOnDemand_Fronter                +0.0447         +0.0449         14726         15384         14717         15378
twitter/SonicOnDemand_NotFound                    +0.0104         +0.0103         25142         25403         25123         25382

Copy link
Collaborator

@xiegx94 xiegx94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuq19 liuq19 merged commit da4f4c3 into bytedance:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants