Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: writebuffer size not include the null terminating #72

Merged
merged 2 commits into from
May 26, 2023
Merged

fix: writebuffer size not include the null terminating #72

merged 2 commits into from
May 26, 2023

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented May 26, 2023

writebuffer not include the null terminating char

@codecov-commenter
Copy link

Codecov Report

Merging #72 (3317a31) into master (2a48a60) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files          21       21           
  Lines        2444     2445    +1     
=======================================
+ Hits         2341     2342    +1     
  Misses        103      103           
Impacted Files Coverage Δ
include/sonic/writebuffer.h 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@xiegx94 xiegx94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuq19 liuq19 merged commit 4825b5e into bytedance:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants