Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the TestPoolPanic function in gopool. Currently it only contains the following test logic
Maybe the original idea is to see if any panic occurs. But actually, the
p.Go
goroutine is not guaranteed to be executed before the main goroutine exits. Chances aretestPanicFunc
never get called. So this test case is actually useless.I add sync.WaitGroup to wait for sub goroutines to finish. Also we need to check if
SetPanicHandler
is working correctly, so I compared the actual execute times with expected times to see if provided panic handler does get called every time when panic occurs.