Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wkg oci push fails if the image ref contains any uppercase letters #134

Open
yoshuawuyts opened this issue Dec 5, 2024 · 4 comments
Open

Comments

@yoshuawuyts
Copy link
Member

WebAssembly/wasi-io#94 was fun to debug - I'm not sure if this is a bug in wkg or a limitation of the OCI reference format?

@brooksmtownsend
Copy link
Contributor

brooksmtownsend commented Dec 5, 2024

I've run into this before 😕 Looks like you have the right workaround. This might just be another GitHub quirk like #40

@yoshuawuyts
Copy link
Member Author

yoshuawuyts commented Dec 5, 2024

I believe #40 was due to the remote, but this error was local to wkg? Though if this needs to be rejected, a better error message provided by wkg here would have been helpful.

@joonas
Copy link
Collaborator

joonas commented Dec 6, 2024

This is actually a requirement of the OCI Distribution spec (which is implemented by GitHub's Container Registry), see the Pulling manifests section for full explanation. In short:

<name> refers to the namespace of the repository. ... Throughout this document, <name> MUST match the following regular expression:

[a-z0-9]+([._-][a-z0-9]+)*(/[a-z0-9]+([._-][a-z0-9]+)*)*

@thomastaylor312
Copy link
Collaborator

Yeah I think I agree with @joonas' comment on bytecodealliance/wkg-github-action#5. We might be able to expose this as a flag, but not sure I'd just want to lowercase things automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants