Issue compiling lucet-runtime crate on osx

[DuncanUszkay1]

Hello- just recently updated my version of lucet-runtime and I can't seem to get it to compile on my machine. It compiles just fine on Debian.

Using MacOS Mojave 10.14.6, rust version 1.38.0

Error:

  = note: Undefined symbols for architecture x86_64:
            "instance_kill_state_exit_guest_region", referenced from:
                _lucet_context_backstop in liblucet_runtime_internals-bc22c96bf26a7eaa.rlib(context_asm.o)
               (maybe you meant: _instance_kill_state_exit_guest_region)
          ld: symbol(s) not found for architecture x86_64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `lucet-runtime`.

Any ideas?

[acfoltzer]

Hi @DuncanUszkay1, the patch we just landed in #338 ought to fix this specific issue. However I will note that there are currently some other outstanding bugs with the experimental Mac OS support that you might run into (e.g., #323).

Please let me know if this helps!

[awortman-fastly]

I wrote some bad assembly, sorry! I don't think that function is made public by the crate, so even though it was #[no_mangle], it got a leading _, so the symbol here should in fact have been _instance_kill_state_exit_guest_region.

This is all moot as of 19 minutes ago because that code was rewritten!

[DuncanUszkay1]

Ah yep that did the trick. Thanks guys!