zeroql.cli does not generate valid C# for schema

[RobTF]

Hi,

I have a schema which results in nullability errors in the generated code. Anyone know if this is the schemas fault or zeroql? The schema has been generated by the HotChocolate GraphQL server.

Schema is below;

schema
  @link(url: "https://specs.apollo.dev/link/v1.0")
  @link(url: "https://specs.apollo.dev/join/v0.3", for: EXECUTION)
{
  query: Query
}

"""A coordinate is an array of positions."""
scalar Coordinates

enum GeoJSONGeometryType
{
  Point @join__enumValue(graph: INCIDENT)
  MultiPoint @join__enumValue(graph: INCIDENT)
  LineString @join__enumValue(graph: INCIDENT)
  MultiLineString @join__enumValue(graph: INCIDENT)
  Polygon @join__enumValue(graph: INCIDENT)
  MultiPolygon @join__enumValue(graph: INCIDENT)
  GeometryCollection @join__enumValue(graph: INCIDENT)
}

interface GeoJSONInterface
{
  type: GeoJSONGeometryType!

  bbox: [Float]

  crs: Int
}

type GeoJSONLineStringType implements GeoJSONInterface
{
  coordinates: [Position]

  type: GeoJSONGeometryType!

  bbox: [Float!]!

  crs: Int!
}

type GeoJSONMultiLineStringType implements GeoJSONInterface
{
  coordinates: [Position]

  type: GeoJSONGeometryType!

  bbox: [Float!]!

  crs: Int!
}

type GeoJSONMultiPointType implements GeoJSONInterface
{
  coordinates: [Position]

  type: GeoJSONGeometryType!

  bbox: [Float!]!

  crs: Int!
}

type GeoJSONMultiPolygonType implements GeoJSONInterface
{
  coordinates: Coordinates

  type: GeoJSONGeometryType!

  bbox: [Float!]!

  crs: Int!
}

type GeoJSONPointType implements GeoJSONInterface
{
  coordinates: Position

  type: GeoJSONGeometryType!

  bbox: [Float!]!

  crs: Int!
}

type GeoJSONPolygonType implements GeoJSONInterface
{
  coordinates: [[Position]]

  type: GeoJSONGeometryType!

  bbox: [Float!]!

  crs: Int!
}

scalar Geometry

scalar Position

type Query
{
	fake: UUID!
}

Errors here...

1><PROJDIR>\GraphQL\Generated.g.cs(65,37,65,40): error CS8767: Nullability of reference types in type of parameter 'value' of 'void GeoJSONMultiPointType.Bbox.set' doesn't match implicitly implemented member 'void GeoJSONInterface.Bbox.set' (possibly because of nullability attributes).
1><PROJDIR>\GraphQL\Generated.g.cs(56,42,56,58): error CS0738: 'GeoJSONMultiPointType' does not implement interface member 'GeoJSONInterface.Crs'. 'GeoJSONMultiPointType.Crs' cannot implement 'GeoJSONInterface.Crs' because it does not have the matching return type of 'int?'.
1><PROJDIR>\GraphQL\Generated.g.cs(33,37,33,40): error CS8767: Nullability of reference types in type of parameter 'value' of 'void GeoJSONLineStringType.Bbox.set' doesn't match implicitly implemented member 'void GeoJSONInterface.Bbox.set' (possibly because of nullability attributes).
1><PROJDIR>\GraphQL\Generated.g.cs(24,42,24,58): error CS0738: 'GeoJSONLineStringType' does not implement interface member 'GeoJSONInterface.Crs'. 'GeoJSONLineStringType.Crs' cannot implement 'GeoJSONInterface.Crs' because it does not have the matching return type of 'int?'.
1><PROJDIR>\GraphQL\Generated.g.cs(49,37,49,40): error CS8767: Nullability of reference types in type of parameter 'value' of 'void GeoJSONMultiLineStringType.Bbox.set' doesn't match implicitly implemented member 'void GeoJSONInterface.Bbox.set' (possibly because of nullability attributes).
1><PROJDIR>\GraphQL\Generated.g.cs(40,47,40,63): error CS0738: 'GeoJSONMultiLineStringType' does not implement interface member 'GeoJSONInterface.Crs'. 'GeoJSONMultiLineStringType.Crs' cannot implement 'GeoJSONInterface.Crs' because it does not have the matching return type of 'int?'.
1><PROJDIR>\GraphQL\Generated.g.cs(81,37,81,40): error CS8767: Nullability of reference types in type of parameter 'value' of 'void GeoJSONMultiPolygonType.Bbox.set' doesn't match implicitly implemented member 'void GeoJSONInterface.Bbox.set' (possibly because of nullability attributes).
1><PROJDIR>\GraphQL\Generated.g.cs(72,44,72,60): error CS0738: 'GeoJSONMultiPolygonType' does not implement interface member 'GeoJSONInterface.Crs'. 'GeoJSONMultiPolygonType.Crs' cannot implement 'GeoJSONInterface.Crs' because it does not have the matching return type of 'int?'.
1><PROJDIR>\GraphQL\Generated.g.cs(97,37,97,40): error CS8767: Nullability of reference types in type of parameter 'value' of 'void GeoJSONPointType.Bbox.set' doesn't match implicitly implemented member 'void GeoJSONInterface.Bbox.set' (possibly because of nullability attributes).
1><PROJDIR>\GraphQL\Generated.g.cs(88,37,88,53): error CS0738: 'GeoJSONPointType' does not implement interface member 'GeoJSONInterface.Crs'. 'GeoJSONPointType.Crs' cannot implement 'GeoJSONInterface.Crs' because it does not have the matching return type of 'int?'.
1><PROJDIR>\GraphQL\Generated.g.cs(113,37,113,40): error CS8767: Nullability of reference types in type of parameter 'value' of 'void GeoJSONPolygonType.Bbox.set' doesn't match implicitly implemented member 'void GeoJSONInterface.Bbox.set' (possibly because of nullability attributes).
1><PROJDIR>\GraphQL\Generated.g.cs(104,39,104,55): error CS0738: 'GeoJSONPolygonType' does not implement interface member 'GeoJSONInterface.Crs'. 'GeoJSONPolygonType.Crs' cannot implement 'GeoJSONInterface.Crs' because it does not have the matching return type of 'int?'.

[byme8]

It is a bug. It fails to align nullability between interface and the struct. I will create an issue for it.

[RobTF]

Great, thanks!