Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit places where we change tags or disconnect alternates in React #198

Closed
gaearon opened this issue Apr 20, 2019 · 1 comment
Closed
Assignees
Labels
😎 enhancement New feature or request

Comments

@gaearon
Copy link
Collaborator

gaearon commented Apr 20, 2019

Cases like #197 (where a dehydrated Suspense node turns into a regular one) produce confusing failures because we expect Fiber alternates to be "for life", whereas in practice they can actually get disconnected by React in some cases. (Search for "Disconnect" in ReactFiberBeginWork.)

Additionally, I think changing tag can also produce confusing failures if it changes from a value that was filtered out, to a value that is not filtered out.

We need to be more proactive about handling these cases when we make such changes to React, and we need to look at existing cases where this happens and whether we can handle them.

@bvaughn
Copy link
Owner

bvaughn commented Aug 19, 2019

This repository is being merged into the main React repo (github.com/facebook/react). As part of this, I am moving all issues to that repository as well and closing them here.

This issue has been relocated to:
facebook/react#16494

@bvaughn bvaughn closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😎 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants