Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cover rules including imported payees. #70

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

bvanelli
Copy link
Owner

@bvanelli bvanelli commented Sep 8, 2024

Implements the imported_payee type that was forgotten because it implements the exact same behaviour as string. There must be a reason why this was implemented, but as of now it implements exacly what STRING implements:

https://github.com/actualbudget/actual/blob/bbff543768eda550569c6e0a0a318446fbafaa0e/packages/loot-core/src/shared/rules.ts#L28-L50

Also trimmed the imported_payee as the original API does, and set it to the payee if it's missing.

Closes #67

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (fb81211) to head (41c7c37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   97.05%   97.06%   +0.01%     
==========================================
  Files          14       14              
  Lines        1904     1911       +7     
==========================================
+ Hits         1848     1855       +7     
  Misses         56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvanelli bvanelli merged commit a341f5a into main Sep 8, 2024
7 checks passed
@bvanelli bvanelli mentioned this pull request Sep 8, 2024
2 tasks
@bvanelli bvanelli deleted the 67-imported-payee-rules branch October 4, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_rules() error
1 participant