Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issue - All page content should be contained by landmarks #12

Open
jaimeiniesta opened this issue Jun 17, 2021 · 2 comments
Open

Accessibility issue - All page content should be contained by landmarks #12

jaimeiniesta opened this issue Jun 17, 2021 · 2 comments

Comments

@jaimeiniesta
Copy link

Hi! Thanks for building this, it works great :)

There's just a little detail, I checked for accessibility issues and Axe complains about this:

Captura de pantalla 2021-06-17 a las 11 35 32

In short, it's because the <canvas> used is not contained inside a landmark. I think that a nice way to fix this would be specifying the element that should be the parent of that <canvas>, defaulting to <body> as it does now.

For example, I could configure Topbar to use the <header> element this way:

topbar.config({
    container  : 'header'
}’

where container could be the identifier of any DOM element.

What do you think?
@buunguyen
Copy link
Owner

I would appreciate a pull request for this. Thanks.

@andresgutgon
Copy link

Did this here:
#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaimeiniesta @andresgutgon @buunguyen