-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make styles look like GitHub's #43
Conversation
Hi, thanks for this. GitHub can't merge this automatically, I think it's because |
Done! |
This is amazing, I totally love it! Thank you! Chrome: there are 2 issues, as below. The first issue is visible when you expand a repo with deep paths (e.g. Angular UI). The second issue is not really a big deal, but I think the previous button background makes it looks better when sitting on text. I'm open to suggestion. Safari: the h1 box is too big. This happens with existing style as well, I hope you can address it in your style. I've packaged the Safari extension here with the new styling, so that you can try (just drag to Safari) without having to register for Safari developer certificate. Finally, I sort of missing the ability to know which file or folder on the tree is being selected. Guess I want close-to-IDE experience. Is there a way to bring it back while blending it seamlessly to the new styling? |
@athaeryn someone on Reddit suggests this design, I think moving the button to the top looks neat and addresses its issue when sitting on top of text: Thought? |
Hey Im the "someone from reddit" only the two css files have changed. |
Oh, that works. Nice! I'm putting the finishing touches on some more styling goodness, should be done soon. :) |
Alright, I'm done for now. When things look good I can squash all these commits. |
@athaeryn This is really really slick! I'm don't quite like the separator and increased height for the nodes though. I'm looking at a large repo (AngularJS) and the tree is too tall. I'd prefer the height and no-separator style of your original design. Other than that, everything looks great and I'm very eager to merge this pull request. |
Thanks! :) That's fair. I was trying to match the GitHub file view, but since they're different views they don't have to be that similar. I'm going to be offline for an hour or so, but I'll play around with decreasing the height when I can. |
Tweak styles Make text overflow ellipsis work on repo name Fix transition so button stays with panel Reduce height of nodes
I've reduced the height a bit, squashed the commits together, and rebased on the latest from master. 👍 |
Make styles look like GitHub's
Merged. I absolutely adore the new look! Excellent job and thanks again for working on this, Mike! |
Awesome! I'm excited to use this -- I'd suggest pushing an update to the Chrome store now that this is in. |
Hopefully I can push to the store this evening and everyone can enjoy @athaeryn's design by tomorrow! |
I'm really glad you enjoy it! I can't take all of the credit though. Putting the toggle button on top was @calumk's idea, and a lot of the styles are just copying GitHub's. I'm sure I'll be contributing to this project in other areas, it's seriously great. |
Well done all! |
This project is awesome! I've done a bit of a design overhaul in order to make the sidebar look like it's part of GitHub.
Most notably, I've used GitHub's icon font for the directory and file icons.
Feel free to question anything I've done. :)