Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BR] Terminal Focus doesn't create new window #178

Closed
2 of 4 tasks
jeff-hykin opened this issue Oct 7, 2020 · 2 comments · Fixed by #179
Closed
2 of 4 tasks

[BR] Terminal Focus doesn't create new window #178

jeff-hykin opened this issue Oct 7, 2020 · 2 comments · Fixed by #179
Labels
bug report 🐛 When something isn't working released 📮 Release has been made

Comments

@jeff-hykin
Copy link
Contributor

jeff-hykin commented Oct 7, 2020

  • I have reset Atom to defaults prior to submitting report.
  • I have not reset Atom to defaults prior to submitting report.
  • I have tried uninstalling/reinstalling the terminal.
  • I have not tried uninstalling/reinstalling the terminal.

Description

@UziTech I see your test in the PR that should cover this case, so I'm not sure how this behavior is happening. But, after doing all the normal restarting/refreshing/reinstalling calling terminal focus still doesn't create a new window for me.

Steps to reproduce

  1. Open A Folder/Project
  2. Call the terminal-focus command with a keybind

Expected behavior:
New x-terminal window

Actual behavior:
If I call terminal-open it'll open up a new terminal in the bottom panel, but terminal-focus does nothing. (I have no other terminals open in any other pane). Errors in the console are a different extension (no errors from x-terminal).
Screen Shot 2020-10-07 at 10 11 48 AM

Reproduces how often:
100%

Versions

Atom : 1.50.0

OS name and version: Mac Sierra
Terminal version: 10.0.1

@UziTech
Copy link
Member

UziTech commented Oct 7, 2020

Thanks for reporting this. It looks like the x-terminal:focus command was set to only run when x-terminal was already focused. This should be fixed by #179.

@github-actions
Copy link

github-actions bot commented Oct 7, 2020

🎉 This issue has been resolved in version 10.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released 📮 Release has been made label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report 🐛 When something isn't working released 📮 Release has been made
Development

Successfully merging a pull request may close this issue.

2 participants