Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local cache folder to avoid repeated downloads of the same entries from the remote cache #3

Open
vlsi opened this issue Jul 25, 2020 · 1 comment

Comments

@vlsi
Copy link
Contributor

vlsi commented Jul 25, 2020

This would improve build performance, reduce S3 costs, and it would reduce network bandwidth usage at the developer's machine.

Relevant Gradle issue: gradle/gradle#13928

@jGleitz
Copy link
Contributor

jGleitz commented Feb 13, 2025

As discussed in the linked issue, this is not an issue as long as the local build cache is enabled. Let’s re-purpose this issue to remove the recommendation in the README.md to disable the local build cache. This recommendation is against what Gradle recommends, and I also don’t find the reasoning convincing:

Local build cache is dangerous as it might produce inconsistent results
in case developer modifies files while the build is running

To trigger this problem, a developer would need to do the modification between when gradle calculates its hashes and when the task actually runs. That is a pretty short window. Also: the local build cache is enabled by default now and it’s not known to cause widespread issues.

Hence, I propose to remove the recommendation from the README.md. We will then get the behaviour @vlsi wants: the local build cache will be populated and preferred over the remote cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants