Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set queue on accessibility announcements in OfflineNoticeProvider #29

Open
burnerlee opened this issue Nov 8, 2024 · 14 comments
Open

Comments

@burnerlee
Copy link
Owner

This is a followup to zulip/zulip-mobile#5344 (once that upgrade is done, as in zulip/zulip-mobile#5610.) We have the following TODO-react-native comments in OfflineNoticeProvider.js:

  // TODO(react-native-68): Use announceForAccessibilityWithOptions to
  //   queue this behind any in-progress announcements
  AccessibilityInfo.announceForAccessibility(_('Zulip’s Internet connection is uncertain.'));

// …
// TODO(react-native-68): Use announceForAccessibilityWithOptions to
// queue this behind any in-progress announcements
AccessibilityInfo.announceForAccessibility(_('Zulip is online.'));
That's referring to this new feature in RN v0.68:
https://reactnative.dev/docs/0.68/AccessibilityInfo#announceforaccessibilitywithoptions

By default announcements will interrupt any existing speech, but on iOS they can be queued behind existing speech by setting queue to true in the options object.

That would be a nice, small, polish tweak.

@burnerlee
Copy link
Owner Author

@dashwave-ci-dev /fix

4 similar comments
@burnerlee
Copy link
Owner Author

@dashwave-ci-dev /fix

@burnerlee
Copy link
Owner Author

@dashwave-ci-dev /fix

@burnerlee
Copy link
Owner Author

@dashwave-ci-dev /fix

@burnerlee
Copy link
Owner Author

@dashwave-ci-dev /fix

@burnerlee
Copy link
Owner Author

@dashwave /fix

8 similar comments
@burnerlee
Copy link
Owner Author

@dashwave /fix

@burnerlee
Copy link
Owner Author

@dashwave /fix

@burnerlee
Copy link
Owner Author

@dashwave /fix

@burnerlee
Copy link
Owner Author

@dashwave /fix

@murex971
Copy link

@dashwave /fix

@murex971
Copy link

@dashwave /fix

@murex971
Copy link

@dashwave /fix

@murex971
Copy link

@dashwave /fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants