Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make release 6.1.3 #1517

Closed
alifeee opened this issue Oct 3, 2024 · 2 comments
Closed

make release 6.1.3 #1517

alifeee opened this issue Oct 3, 2024 · 2 comments

Comments

@alifeee
Copy link
Collaborator

alifeee commented Oct 3, 2024

I tried, see release: https://github.com/burnash/gspread/releases/tag/v6.1.3

the workflow failed: https://github.com/burnash/gspread/actions/runs/11163751573/job/31031449158

Run pypa/gh-action-pypi-publish@release/v1
/usr/bin/docker run --name dfd4b13f31f3f1eef49c0a63236d2ec0d073e_bf66bb --label 8dfd4b --workdir /github/workspace --rm -e "pythonLocation" -e "PKG_CONFIG_PATH" -e "Python_ROOT_DIR" -e "Python2_ROOT_DIR" -e "Python3_ROOT_DIR" -e "LD_LIBRARY_PATH" -e "INPUT_USER" -e "INPUT_PASSWORD" -e "INPUT_REPOSITORY-URL" -e "INPUT_REPOSITORY_URL" -e "INPUT_PACKAGES-DIR" -e "INPUT_PACKAGES_DIR" -e "INPUT_VERIFY-METADATA" -e "INPUT_VERIFY_METADATA" -e "INPUT_SKIP-EXISTING" -e "INPUT_SKIP_EXISTING" -e "INPUT_VERBOSE" -e "INPUT_PRINT-HASH" -e "INPUT_PRINT_HASH" -e "INPUT_ATTESTATIONS" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -
Warning: Trusted Publishers allows publishing packages to PyPI from automated environments like GitHub Actions without needing to use username/password combinations or API tokens to authenticate with PyPI. Read more: https://docs.pypi.org/trusted-publishers
Warning: A new Trusted Publisher for the currently running publishing workflow can be created by accessing the following link(s) while logged-in as an owner of the package(s):
- https://test.pypi.org/manage/project/gspread/settings/publishing/?provider=github&owner=burnash&repository=gspread&workflow_filename=release.yaml
Checking dist/gspread-6.1.3-py3-none-any.whl: PASSED
Checking dist/gspread-6.1.3.tar.gz: PASSED
Uploading distributions to https://test.pypi.org/legacy/
Uploading gspread-6.1.3-py3-none-any.whl
WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         Bad Request  

the error is ERROR HTTPError: 400 Bad Request from https://test.pypi.org/legacy/

is this to do with trusted publishers? #1331 I am not sure

when this release is made, the following threads should be notified as such: #1504 #1510 #1512 #1516

@alifeee
Copy link
Collaborator Author

alifeee commented Oct 3, 2024

the release notes should be:

## What's Changed
* ignore jinja CVE by @lavigne958 in https://github.com/burnash/gspread/pull/1481
* Remove passing exception as args to super in APIError by @mike-flowers-airbnb in https://github.com/burnash/gspread/pull/1477
* better handler API error parsing. by @lavigne958 in https://github.com/burnash/gspread/pull/1510
* Add test on receiving an invalid JSON in the APIError exception handler. by @lavigne958 in https://github.com/burnash/gspread/pull/1512

## New Contributors
* @mike-flowers-airbnb made their first contribution in https://github.com/burnash/gspread/pull/1477

@alifeee
Copy link
Collaborator Author

alifeee commented Oct 3, 2024

done

a new release 6.1.3 has been released (on github) (on PyPi) which contains a fix for this issue

we now catch the non-JSON error and turn it into a GSpreadException which should be easier to catch and find out what went wrong with the request

see more context here: #1510

@alifeee alifeee closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant