Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Pypi Trusted Publisher #1331

Open
lavigne958 opened this issue Oct 25, 2023 · 6 comments · May be fixed by #1447
Open

Investigate Pypi Trusted Publisher #1331

lavigne958 opened this issue Oct 25, 2023 · 6 comments · May be fixed by #1447

Comments

@lavigne958
Copy link
Collaborator

Overview

We should enable trusted publishers in order to publish packages to TestPypi and Pypi without the need of passwords and username. (Don't know if we need it but it's worth checking-out)
@alifeee
Copy link
Collaborator

alifeee commented Oct 25, 2023

blog post about why: https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/

how-to guide: https://docs.pypi.org/trusted-publishers/

@alifeee alifeee added the Need investigation This issue needs to be tested or investigated label Oct 25, 2023
@lavigne958
Copy link
Collaborator Author

I went through the doc, we can't use it for now, only the owner of the project can do it.

We need @burnash assistance for this. please.

@burnash
Copy link
Owner

burnash commented Mar 28, 2024

Hi @lavigne958, thanks for pinging me. I've added the new GitHub publisher for this repo to Trusted Publishers with these settings:
Workflow: release.yaml
Environment name: release

@lavigne958
Copy link
Collaborator Author

Hi thank you for the prompt reply !
thanks for the settings, we'll update the release workflow and test it next time we release.

lavigne958 added a commit that referenced this issue Mar 28, 2024
@lavigne958
Add pypi trusted publisher
186c457 
Remove use of token, use Pypi OIDC from github.

closes #1331

Signed-off-by: Alexandre Lavigne <[email protected]>
@lavigne958 lavigne958 linked a pull request Mar 28, 2024 that will close this issue
Open
@lavigne958 lavigne958 added this to the 6.2.0 milestone Mar 28, 2024
@lavigne958 lavigne958 added in progress Issue currently in progress by the assignee and removed Need investigation This issue needs to be tested or investigated labels Apr 6, 2024
@lavigne958 lavigne958 removed the in progress Issue currently in progress by the assignee label May 12, 2024
@lavigne958
Copy link
Collaborator Author

@burnash I am wondering, did you create the release environment in the repository ? I don't have access to it, I can't check.

I did not manage to make it work, I believe it could be because the env does not exist.

@lavigne958 lavigne958 removed this from the 6.2.0 milestone Jun 17, 2024
@lavigne958
Copy link
Collaborator Author

I removed this issue from next release as for now we are stuck until we manged to make a new release using the trusted publisher workflow

@alifeee alifeee mentioned this issue Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pypi trusted publisher burnash/gspread
3 participants
@burnash @alifeee @lavigne958