Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown() panic under certain conditions #177

Closed
aathan opened this issue Jul 29, 2022 · 2 comments
Closed

Shutdown() panic under certain conditions #177

aathan opened this issue Jul 29, 2022 · 2 comments
Assignees
@buraksezer
Labels
bug Something isn't working

Comments

@aathan
Copy link

aathan commented Jul 29, 2022

I believe the code in func (d *Discovery) Shutdown() error must guard against d.memberList being nil.

Under certain startup conditions, memberList may not be fully initialized by the time this code runs.
If I can re-create the condition I'll post more details.
@buraksezer buraksezer self-assigned this Jul 29, 2022
@buraksezer buraksezer added the bug Something isn't working label Jul 29, 2022
@buraksezer
Copy link
Owner

Hi @aathan, thank you for reporting this.

I'll investigate the problem. Is there any traceback for this problem? Which version do you use? v0.5.x tree already has a nil check in Discovery.Shutdown.

@buraksezer buraksezer mentioned this issue Aug 19, 2022
Merged
@buraksezer
Copy link
Owner

Hello,

I have backported the fix and released v0.4.6. I'm closing this issue now. If you have any further problems or questions, please don't hesitate to open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buraksezer buraksezer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aathan @buraksezer