This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
add debug log for api request limit #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -302,6 +302,7 @@ def remote_specs | |||
| # the gemspecs of those gems, if the non-api sites contain more than | |||
| # about 100 gems, we just treat all sites as non-api for speed. | |||
| allow_api = idx.size < API_REQUEST_LIMIT && dependency_names.size < API_REQUEST_LIMIT | |||
| Bundler.ui.debug "Need to query more then #{API_REQUEST_LIMIT} gems" unless allow_api | |||
There was a problem hiding this comment.
Can we add a bit more information?
Need to query more than 200 gems. Downloading full index instead...
There was a problem hiding this comment.
Sure.
My first version included such info, but I've removed it since the current output will be:
$ DEBUG=1 bundle
HTTP GET https://bundler.rubygems.org/api/v1/dependencies
HTTP 200 OK
Need to query more then 100 gems
Fetching source index from https://rubygems.org/
Do you think the following is better?:
$ DEBUG=1 bundle
HTTP GET https://bundler.rubygems.org/api/v1/dependencies
HTTP 200 OK
Need to query more then 100 gems. Downloading full index instead...
Fetching source index from https://rubygems.org/
There was a problem hiding this comment.
I like the second one better. Cause and effect.
Also, could you change then to than? Thank you.
neerfri
force-pushed
the
add-debug-message-for-api-request-limit
branch
from
1aed63e to
10995e0
Compare
|
👍 |
TimMoore
added a commit
that referenced
this pull request
Mar 3, 2015
…st-limit add debug log for api request limit
|
Thanks! |
|
My pleasure |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.