Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jobInfoChips display issue on mobile devices #470

Merged
merged 2 commits into from
May 24, 2022
Merged

Fix jobInfoChips display issue on mobile devices #470

merged 2 commits into from
May 24, 2022

Conversation

shredxt
Copy link
Contributor

@shredxt shredxt commented May 5, 2022

On mobile devices currently, the jobInfoChips are overlapping the Job Title, this change resolves this issue. This PR should resolve Issue #468 for Mobile users. I wasn't able to repro the issue in a Desktop environment.

Additions / Removals

Nothing was added or removed, just amended one of the CSS values.

Testing

Tested on Chrome on Android and using Dev Tools Mobile View on Chrome Desktop.

Screenshots

image
image

Notes

This flex-direction value can also be defined as 'row' or potentially even be removed entirely since it appears to have no negative effect when removed (see screenshots)? It also has no effect (obviously) on the Desktop site since it is a mobile-only value.

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the contributing guide
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices

shredxt added 2 commits May 5, 2022 17:57
On mobile devices currently, the jobInfoChips are overlapping the Job Title, this change resolves this issue.
Fix jobInfoChips display issue on mobile devices
@hiqbal01
Copy link

@shredxt does this still look good on desktops? Also did we try the fix in a couple different browsers?

@shredxt
Copy link
Contributor Author

shredxt commented May 24, 2022

This issue was also affecting Desktop users if the window width was below 768px, can confirm that the changes above resolve the issue on Desktop too.

Recording.45.mp4

Additional testing was done on Firefox on Desktop and Chrome on Mobile.

@acrowe2 acrowe2 merged commit a2b4ae3 into bullhorn:master May 24, 2022
@joshdraha
Copy link

Where is this code located? If I need to add it, what file do I add it to and what is the file path?

@joshdraha
Copy link

@hiqbal01 - Where is this code located? If I need to add it, what file do I add it to and what is the file path?

@maverick2030
Copy link

Same problem as the comments above. Where is the file / code located?

@joshdraha
Copy link

@maverick2030 @SherpaGreg they won't answer you nor are they any help. I went on Fiverr and found someone to fix the issue.

@SherpaGreg
Copy link

SherpaGreg commented Jul 27, 2022 via email

@margotliberty
Copy link

Well I'm a Bullhorn user with this same issue. Did anyone figure out how to make this correction? Do we know which file needs to be edited and on which line? Any assistance would be greatly appreciated.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants