Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot include yaml fragments in junction elements #1370

Open
Cynical-Optimist opened this issue Oct 14, 2020 · 0 comments
Open

Cannot include yaml fragments in junction elements #1370

Cynical-Optimist opened this issue Oct 14, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Cynical-Optimist
Copy link

See original issue on GitLab
In GitLab by [Gitlab user @tristanvb] on Jul 21, 2020, 11:25

Currently we have an undocumented limitation, which is that we fail to expand ([[Gitlab user @]](https://gitlab.com/)) files when these are declared inside a junction element.

This is not mentioned in the include documentation or in the junction documentation.

While it is possible to end up in unresolvable situations by allowing includes in junctions, it is perfectly possible to allow, we just need to have the correct early stage LoadErrors in place if ever an include leads to a circular reference into the same project that the given junction is loading. This error is already probably accounted for by LoadErrorReason.CIRCULAR_REFERENCE which is checked for and raised in the Loader.get_loader() API.

In the worst case, we need to document this as unsupported, but I think we should support this.

@Cynical-Optimist Cynical-Optimist added the bug Something isn't working label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant