[0.11.x] Bump lifecycle to 0.17.2 #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is the highest we can go without backwards incompatible changes. this will introduce new Platform API version (although they won't be used because we hardcode supported versions), and Buildpack API versions. Signed-off-by: Bohan Chen <[email protected]>
chenbh
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/v0.11.x #1435 +/- ##
================================================
Coverage 67.83% 67.83%
================================================
Files 132 132
Lines 8071 8071
================================================
Hits 5475 5475
Misses 2166 2166
Partials 430 430 ☔ View full report in Codecov by Sentry. |
tomkennedy513
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lifecycle image is built with an older version of go that contains CVEs, this means that both the kpack deployment, the builder pod, and even the built app image will show up in scanners. By bumping to 0.17.2 (which is the highest backwards-compatible version), it at leasts resolves CVEs from the go stdlib (there's still go.mod CVEs, but not much we can do about that since lifecycle doesn't patch older versions).
The user facing changes would be that Buildpack API v0.9 and v0.10 would now be supported (we hard code the supported Platform API versions) . See https://github.com/buildpacks/lifecycle?tab=readme-ov-file#supported-apis for more details