Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kpack doesn't scale for large clusters with the current client side rate limits #1666

Closed
sambhav opened this issue Jul 15, 2024 · 1 comment · Fixed by #1667
Closed

kpack doesn't scale for large clusters with the current client side rate limits #1666

sambhav opened this issue Jul 15, 2024 · 1 comment · Fixed by #1667

Comments

@sambhav
Copy link
Contributor

sambhav commented Jul 15, 2024

Currently kpack has a bunch of limiters that prevent it from scaling effectively for large cluster (for eg. we have a cluster with over 3000 image resources)

The main limiters are -

We have an internal patch on the kpack controller to bump up rate limits so that it scales to large multi-tenant clusters. We would love to contribute the change upstream. It largely involves changing the following three vars via a single scale-factor cli arg that multiplies the default values with the user provided scale factor.

Would yall be open to a small PR to make these rates configurable? We have been able to scale to close to 3k images and our reconcile time improved from 4mins to <1s post our changes.

@tomkennedy513
Copy link
Collaborator

That sounds great

@sambhav sambhav changed the title kpack doesn't scale for large cluster with the current client side rate limits kpack doesn't scale for large clusters with the current client side rate limits Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants