Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canceled builds do not show as canceled in the pull request #114

Open
voidrender opened this issue Aug 20, 2015 · 2 comments
Open

Canceled builds do not show as canceled in the pull request #114

voidrender opened this issue Aug 20, 2015 · 2 comments
Labels
task-medium up-for-grabs

Comments

@voidrender
Copy link
Contributor

Integrations canceled because of a new commit continue to show as "building..." in the pull request. See #112 for additional information.
builda-112
@czechboy0 czechboy0 added the bug label Aug 20, 2015
@czechboy0 czechboy0 self-assigned this Aug 20, 2015
@czechboy0
Copy link
Member

This will require a bit more logic to be added: namely, resolveActionsForCommitAndIssueWithBotIntegrations in SyncPairResolver will need to keep a map from commits to an array of integrations performed for that commit. Then, we would resolve not just the last commit, but all commits to their corresponding statuses and update all of the affected commits.

This could work. Sorry, @ioveracker if this doesn't make much sense, I'm just thinking out loud 😊

@czechboy0 czechboy0 removed their assignment Sep 25, 2015
@s-faychatelard
Copy link

+1 on this, I like to have clean PRs 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task-medium up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@s-faychatelard @voidrender @czechboy0