Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 9.0.0 and 9.1.0 #4

Closed
Klaim opened this issue Dec 10, 2022 · 6 comments
Closed

Release 9.0.0 and 9.1.0 #4

Klaim opened this issue Dec 10, 2022 · 6 comments

Comments

@Klaim
Copy link
Collaborator

Klaim commented Dec 10, 2022

As requested by @Wmbat

Current master branch is ready for 9.0.0 but I'm seeing issues in the CI that I have trouble interpreting: https://ci.stage.build2.org/@7bbdfe7f-ddbd-4400-914f-38514d281862?builds=&pv=&th=*&tg=&tc=&pc=&rs=error

Same issues with 9.1.0: https://ci.stage.build2.org/@6e70e722-0974-4740-8b1a-92578f51a83f?builds=&pv=&th=*&tg=&tc=&pc=&rs=error

Apparently some recent versions of MSVC cause issues. Locally I have a preview version installed and do not see these issues. However I'm seeing similar reports using clang-15.0.6

I'm investigating.

@Klaim
Copy link
Collaborator Author

Klaim commented Dec 10, 2022

I notified @vitaut to see if it's known issues or not.

@Klaim
Copy link
Collaborator Author

Klaim commented Dec 11, 2022

Welp @vitaut don't know about these issues so this is probably new, some untested situations.
I'll try a workaround or remove support for these specific ones.

@Klaim
Copy link
Collaborator Author

Klaim commented Dec 11, 2022

I actually managed to reproduce the issue in compiler explorer and investigate, it seems related to using c++20 with msvc 14.32/1932 and 14.33/1933 but not the latest versions (except when mixed up with clang, at least on my local setup).
Report: fmtlib/fmt#3224

I will just mark the packages to ignore these specific versions as recent versions of msvc will work.

@Klaim
Copy link
Collaborator Author

Klaim commented Dec 11, 2022

The issue can be worked around by avoiding depending on ADL, so I'll actually send a revision of the package (see fmtlib/fmt#3224 for details)

@Klaim
Copy link
Collaborator Author

Klaim commented Dec 11, 2022

@Klaim
Copy link
Collaborator Author

Klaim commented Dec 12, 2022

These packages are now available on cppget: https://cppget.org/fmt

@Wmbat I think you can proceed with the spdlog update. Ping me if you find issues 👍🏽

@Klaim Klaim closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant