Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(auth): Azure AD OAuth #741

Open
0lionelzhang0 opened this issue Mar 25, 2024 · 2 comments
Open

feature(auth): Azure AD OAuth #741

0lionelzhang0 opened this issue Mar 25, 2024 · 2 comments
Labels

Comments

@0lionelzhang0
Copy link
Contributor

Hello!

Thank you bugy for this amazing tool. I was wondering if there are any plans to add auth support for Azure AD OAuth?

If not, would you mind providing some pointers on how one could implement that?

Thanks!

@bugy
Copy link
Owner

bugy commented Mar 26, 2024

Hi, unfortunately, it's not supported. But if it's more or less the standard OAuth implementation, it should be quite straightforward to implement.
Here is an example of Google OAuth: https://github.com/bugy/script-server/blob/master/src/auth/auth_google_oauth.py
It's pretty small, since the main implementation is located in the parent OAuth class: https://github.com/bugy/script-server/blob/master/src/auth/auth_abstract_oauth.py

Besides this class, the following things should be updated:

@bugy bugy added the feature label Mar 26, 2024
@0lionelzhang0
Copy link
Contributor Author

Thank you, bugy. I will look into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants